Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot find function names for ES6 static functions #37

Closed
rhart opened this issue May 13, 2016 · 1 comment
Closed

Cannot find function names for ES6 static functions #37

rhart opened this issue May 13, 2016 · 1 comment
Assignees
@eriwen
Milestone
3.0

Comments

@rhart
Copy link

rhart commented May 13, 2016

Expected Behavior

With a method that throws an error like:

static generate() {
    throw new Error('Boom');
}

the function name generate should be returned from _findFunctionName

Current Behavior

Currently undefined is returned from _findFunctionName and a stack frame with an already populated function name from error.stack is replaced as
{anonymous}()@webpack:///src/main/lib/foo.js:15:10

Your Environment

  • stacktrace.js version: 1.1.2
  • Browser Name and version: Chrome 50.0.2661.94 (64-bit)
  • Operating System and version (desktop or mobile): Yosemite
eriwen added a commit that referenced this issue May 14, 2016
@eriwen
Related to #37, don't replace non-empty function names with undefined…
269ec18 
… if findFunctionName doesn't find anything
@eriwen eriwen self-assigned this Dec 1, 2016
@eriwen eriwen added this to the 3.0 milestone Dec 1, 2016
eriwen added a commit that referenced this issue Dec 10, 2016
@eriwen
Add function name parsing for ES6 static functions
c61d2b0 
- Add parsing for static functions
- Fix JSCS warnings

Issue: #37
@eriwen
Copy link
Member

eriwen commented Dec 10, 2016

Fixed with c61d2b0

@eriwen eriwen closed this as completed Dec 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eriwen eriwen

Labels
None yet
Milestone
3.0
Development

No branches or pull requests
2 participants
@eriwen @rhart