Source map improvements: Resolve content from sourceContent and fix inline source map issue #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please be sure to fix jshint errors ;) |
|
JSHint warnings are now fixed. Tests are passing locally too, but CI seems to fail: |
|
Humm, not sure about that. @eriwen might know how to fix this. |
|
Thank you very much for the PR! Something is wrong with the GitHub Sauce config. Not your fault, Kenneth. If the tests are passing locally we can merge this. On Fri, Sep 18, 2015 at 5:29 AM, Oliver Salzburg notifications@github.com
|
ssenbud
added a commit
that referenced
this pull request
Sep 20, 2015
Source map improvements: Resolve content from sourceContent and fix inline source map issue
|
Yay 👍 |
This was referenced Sep 20, 2015
eriwen
added a commit
that referenced
this pull request
Apr 16, 2016
Source map improvements: Resolve content from sourceContent and fix inline source map issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue of inline source maps (data-urls) being prepended with base url (#17), and adds the logic to extract sourceContent from source map and inject into cache, which makes source mapped assets resolvable by the
_getmethod.This could probably be covered by a new test.