Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 #158

Closed
ghost opened this issue Sep 30, 2015 · 14 comments
Closed

Python 3 #158

ghost opened this issue Sep 30, 2015 · 14 comments

Comments

@ghost
Copy link

ghost commented Sep 30, 2015

I note that Hook supports Python 2, which is a nice start, but is already outdated. Are ye planning to support a more modern version of Python, such as 3.4 or even 3.5?

Thanks!

@Marak
Copy link
Collaborator

Marak commented Oct 1, 2015

I see the server is on:

Python 2.7.6

There's no reason why can't move to 3.x. I just have the check compatibility with Node.js and npm because I know it uses Python for some things.

I'll see what we can do. Thanks!

@waylonflinn
Copy link

👍

@Marak
Copy link
Collaborator

Marak commented Oct 3, 2015

The people have spoken!

I've updated the priority of this issue and have placed the feature On Deck. Will have an update shortly.

If anyone is interested in tracking hook.io feature development we have a public Trello board available here: https://trello.com/b/9i9QSbof/hook-io-features

@Marak
Copy link
Collaborator

Marak commented Oct 10, 2015

I did some research and have found that node-gyp and gyp will never support python3.

That's okay, as we can easily have both versions exist on production.

Will install python3 on production in the next day.

Sorry for the delay. Was traveling during the week.

@waylonflinn
Copy link

Perfect timing! I was just thinking about how to spin up my own on AWS.

@ghost
Copy link
Author

ghost commented Oct 11, 2015

Fantastic news, thanks! You made my breakfast. :)

On 10 October 2015 23:28:35 IST, Waylon Flinn notifications@github.com wrote:

Perfect timing! I was just thinking about how to spin up my own on AWS.


Reply to this email directly or view it on GitHub:
#158 (comment)

Sent from my Android device with K-9 Mail. Please excuse my brevity.

@Marak
Copy link
Collaborator

Marak commented Oct 11, 2015

Got everything working locally in testing.

The only concern I have now is that a few users have already created hooks using python2.

Do you think we can drop support for python 2 entirely? Or should we keep both versions available?

@Marak
Copy link
Collaborator

Marak commented Oct 11, 2015

Since it's not going to be that difficult to support both, I'm going to keep support for both versions.

Will need to update the examples and should have this deployed in the next few hours.

@waylonflinn
Copy link

Yay!

Good call on Python 2. The tide is finally turning, but lots haven't moved yet.


Sent from Mailbox

On Sun, Oct 11, 2015 at 2:01 PM, Marak notifications@github.com wrote:

Since it's not going to be that difficult to support both, I'm going to keep support for both versions.

Will need to update the examples and should have this deployed in the next few hours.

Reply to this email directly or view it on GitHub:
#158 (comment)

Marak added a commit that referenced this issue Oct 11, 2015
 * Adds new `run-hook-python3` binary
 * Adds new python3 examples and code gateway
 * Updates view to show new language option
@Marak
Copy link
Collaborator

Marak commented Oct 11, 2015

We should now have support for both python and python3 online.

http://hook.io/marak/examples-python3-hello-world
http://hook.io/marak/examples-python3-hello-world/source

Please let me know if you run into any issues. Thanks!

Sorry again this took so long to turn around. Lost about a week to travel. I will now be more available.

@louis77
Copy link

louis77 commented Oct 12, 2015

Hi guys

I've recently joined the Python developers community and know that there is still some discussion around version 2 and version 3. Personally, I don't see the point in supporting an old version of Python for hook.io, since hook.io is not about deploying existing apps. Most likely one will write new functions to be deployed here.

Python 3 supports a lot of new features and cleans up the language a lot. Also performance is a big plus in Python 3 from my experience. It was released 2008, so it's not that new after all. If there is a decision to support Python 2 too, why not supporting Ruby 1, Node 0.x, and all the other old versions of all the other languages too?

@ghost
Copy link
Author

ghost commented Oct 12, 2015

Having started allowing customers to use Py2 the Hook people have a responsibility not to simply pull the rug right away, though with a sunset on Py2 support in the nnear future it'll eventually happen.

A mid-road option is to simply disallow new projects using outdated and soon discontinued runtimes, which limits technical debt to existing code only. However, the burden of maintaining that technical debt lies with the Hook team so it's their call.

I'm just grateful for the upgrade! :)

On 12 October 2015 09:45:05 IST, Louis Brauer notifications@github.com wrote:

Hi guys

I've recently joined the Python developers community and know that
there is still some discussion around version 2 and version 3.
Personally, I don't see the point in supporting an old version of
Python for hook.io, since hook.io is not about deploying existing apps.
Most likely one will write new functions to be deployed here.

Python 3 supports a lot of new features and cleans up the language a
lot. Also performance is a big plus in Python 3 from my experience. It
was released 2008, so it's not that new after all. If there is a
decision to support Python 2 too, why not supporting Ruby 1, Node 0.x,
and all the other old versions of all the other languages too?


Reply to this email directly or view it on GitHub:
#158 (comment)

Sent from my Android device with K-9 Mail. Please excuse my brevity.

@Marak
Copy link
Collaborator

Marak commented Oct 12, 2015

We already made the decision to support both versions.

@Marak Marak closed this as completed Oct 12, 2015
@pyhedgehog
Copy link

@cathalgarvey, @waylonflinn and @louis77, please join discussion important for python support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants