Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad require in stack bin file. #10

Closed
labajo opened this issue Oct 13, 2016 · 2 comments
Closed

Bad require in stack bin file. #10

labajo opened this issue Oct 13, 2016 · 2 comments

Comments

@labajo
Copy link

labajo commented Oct 13, 2016

In stack/bin/stack file the require in the following line fails:
https://github.com/Stackvana/stack/blob/master/bin/stack#L39

I think it should be

var viewPresenter =  #require('../lib/viewPresenter');
@Marak
Copy link
Collaborator

Marak commented Oct 13, 2016

Ahh! Sorry about that, will patch now and publish.

Marak added a commit that referenced this issue Oct 13, 2016
@Marak
[fix] Switch viewPresenter back to module #10
0225f99 
  * Having issues with viewPresenter as plugin
  * viewPresenter requires patching response obj
  * Is now working up-stream and with examples
@Marak
Copy link
Collaborator

Marak commented Oct 13, 2016

Should be resolved and published with v3.0.1

@Marak Marak closed this as completed Oct 13, 2016
Marak added a commit that referenced this issue Oct 13, 2016
@Marak
[fix] Switch viewPresenter back to module #10
35024aa 
  * Having issues with viewPresenter as plugin
  * viewPresenter requires patching response obj
  * Is now working up-stream and with examples
Conflicts:
	bin/stack
	lib/spawn.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Marak @labajo