A bit of linting #107
Merged
A bit of linting #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* unpublished crates should not have version, and should have `publish=false` * add clippy lints to workspace * worked through a number of clippy suggestions
|
Looks like we need to bump the MSRV (seems like 1.75 added support for version-less packages): rust-lang/cargo#12786 |
ianthetechie
approved these changes
May 9, 2024
|
Just an FYI for next time: even changes to comments in the generated bindings result in UniFFI's pedantic integrity checksums failing ;) Normally one would simply not commit generated bindings, but regrettably I haven't yet figured out a way to avoid this given the... quirks of how SPM works. Android doesn't have this problem. So, TL;DR, you'll need to run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
publish=false