Refactor to cleanup and prepare for directory caching #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyurik
force-pushed
the
refactor-for-cache
branch
2 times, most recently
from
970fed0
to
2cb2cfe
Compare
Merged
nyurik
force-pushed
the
refactor-for-cache
branch
from
2cb2cfe
to
a251b52
Compare
* there is no point in returning type and compression with every `get_tile` -- PMTiles keeps this data in the header, so it is constant, and if the user needs it, they can get it directly. Returns `bytes` now. * add `Entry::is_leaf` helper * add `Header::get_bounds` and `Header::get_center` (tilejson structs) * no need for `AsyncPmTilesReader<B: ...>` type - it has to be specified in the impl anyway * no need for the `backend::read_initial_bytes` - it is only used once, has default implementation anyway. Inlined. * inlined `read_directory_with_backend` - used once and tiny * split up the `find_tile_entry` into two functions - I will need this later to add caching -- the root entry is permanently cached as part of the main struct, but the other ones are not, so needs a different code path. * added `cargo test` for default features
nyurik
force-pushed
the
refactor-for-cache
branch
from
a251b52
to
eb0a896
Compare
lseelenbinder
approved these changes
Nov 10, 2023
There was a problem hiding this comment.
Looks good to me. Could simplify one function, but it's not strictly necessary.
Thanks @nyurik!
nyurik
force-pushed
the
refactor-for-cache
branch
2 times, most recently
from
84cdfd0
to
eb0a896
Compare
|
it ended up being more complicated because I would have to re-wrap entry as an option |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_tile-- PMTiles keeps this data in the header, so it is constant, and if the user needs it, they can get it directly. Returnsbytesnow.Entry::is_leafhelperHeader::get_boundsandHeader::get_center(tilejson structs)AsyncPmTilesReader<B: ...>type - it has to be specified in the impl anywaybackend::read_initial_bytes- it is only used once, has default implementation anyway. Inlined.read_directory_with_backend- used once and tinyfind_tile_entryinto two functions - I will need this later to add caching -- the root entry is permanently cached as part of the main struct, but the other ones are not, so needs a different code path.cargo testfor default features