Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lots of lints and clippy things #26

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Lots of lints and clippy things #26

merged 1 commit into from
Nov 20, 2023

Conversation

nyurik
Copy link
Collaborator

@nyurik nyurik commented Nov 20, 2023

  • use [lints] Cargo.toml sections
  • added a few fixme/todos to the code - we don't need to solve them now, but they should remind us to look at them at some point - might be a source of bugs there.

* use `[lints]` Cargo.toml sections
* added a few fixme/todos to the code - we don't need to solve them now, but they should remind us to look at them at some point - might be a source of bugs there.
@nyurik nyurik merged commit b2bb41a into stadiamaps:main Nov 20, 2023
1 check passed
@nyurik nyurik deleted the linting branch November 20, 2023 20:50
@nyurik
Copy link
Collaborator Author

nyurik commented Nov 20, 2023

@lseelenbinder do you think there is a bug with src/async_reader.rs ? See my comment at the top, and try to comment it out to see the warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants