Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Currency-Conv Api Key always stored in file #12

Closed
stadub opened this issue Sep 4, 2019 · 0 comments
Closed

Currency-Conv Api Key always stored in file #12

stadub opened this issue Sep 4, 2019 · 0 comments
Labels
bug

Comments

@stadub
Copy link
Owner

stadub commented Sep 4, 2019

Describe the bug
Currency-Conv Api Key always stored in file but for some users, it can be very sensitive information

Expected behavior
User should have the ability to decide if he wants to store info either enter during each module load
@stadub stadub changed the title Currency-Conv Api Key always stored in file [bug] Currency-Conv Api Key always stored in file Sep 4, 2019
@stadub stadub added the bug label Sep 4, 2019
@stadub stadub changed the title [bug] Currency-Conv Api Key always stored in file Currency-Conv Api Key always stored in file Sep 4, 2019
stadub added a commit that referenced this issue Sep 9, 2019
@stadub
Added cacheing #11 Added save-prompt #12
e81d9b7
@stadub stadub mentioned this issue Sep 9, 2019
Merged
stadub added a commit that referenced this issue Sep 9, 2019
@stadub
Merge pull request #13 from stadub/Currency-Conv-Release-1.5
e3ff052 
added requests  caching #11  and save ApiKey prompt #12
@stadub stadub closed this as completed Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stadub