Convert scons scripts to Python 3. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, it looks like #3 does this in addition to the other compatibility changes. I'm leaving this open just in case you want to merge this before you get around to merging the compatibility branch, but feel free to close this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the build files use Python 2, which is not supported by recent versions of Scons (nor is the interpreter itself supported). I ran
2to3on the Scons build files, and I manually replacedfilewithopen. After these changes, it built successfully on Ubuntu 21.04.Running the tools seemed to work, too. I did have some WxWidgets errors regarding a invalid DC that didn't seem to interfere with the running of the program and seem unrelated.