upgraded the CRD version to apiextensions.k8s.io/v1

[sherifkayad]

Currently newer version of k8s are throwing:

Warning: apiextensions.k8s.io/v1beta1 CustomResourceDefinition is deprecated in v1.16+, unavailable in v1.22+; use apiextensions.k8s.io/v1 CustomResourceDefinition
customresourcedefinition.apiextensions.k8s.io/forecastleapps.forecastle.stakater.com unchanged

This PR upgrades the CRD version to apiextensions.k8s.io/v1

[sherifkayad]

@ahmedwaleedmalik Did you have the time to have a look at this one?

[sherifkayad]

@ahmedwaleedmalik any updates on this? I believe that could be a quick win

[ahmedwaleedmalik]

Hi @sherifkayad,

Sorry but I don't actively work on these repositories. Anyways, in v1 there are schematic changes as well along with the change in apiVersion. So we cannot directly just change the apiVersion. Did you try and install the CRDs on your local cluster? It fails with the error:

The CustomResourceDefinition "forecastleapps.forecastle.stakater.com" is invalid: spec.versions[0].schema.openAPIV3Schema: Required value: schemas are required

An easier way for this conversion would be to install it in a k8s v1.18+ cluster, create the CRD there and then retrieve the installed resource from the cluster:

kubectl get crd forecastleapps.forecastle.stakater.com -oyaml

It converts CRDs that use v1beta1 to v1 automatically, behind the curtains.

[sherifkayad]

@ahmedwaleedmalik I just updated the CRD as per the output of my v18+ k8s cluster. Can you have a look?

[stakater-user]

@sherifkayad Image is available for testing. docker pull stakater/Forecastle:SNAPSHOT-PR-155-501712d0

[ahmedwaleedmalik]

Merged, LGTM