Skip to content

Commit

Permalink
use trim for multiple watch namespaces
Browse files Browse the repository at this point in the history
  • Loading branch information
kahootali committed May 3, 2021
1 parent 8d430df commit 3c189ee
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/pull_request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,7 @@ jobs:
- name: Check out code
uses: actions/checkout@v2
with:
fetch-depth: 0
ref: ${{ github.head_ref }}
ref: ${{github.event.pull_request.head.sha}}

- name: Set up Go
id: go
Expand Down
2 changes: 1 addition & 1 deletion deploy/chart/ingressmonitorcontroller/templates/role.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ apiVersion: rbac.authorization.k8s.io/v1
kind: Role
metadata:
name: {{ template "name" $ }}-role
namespace: {{ . | quote }}
namespace: {{ . | trim }}
labels:
{{ include "labels" $ | indent 4 }}
rules:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,14 @@ kind: RoleBinding
apiVersion: rbac.authorization.k8s.io/v1
metadata:
name: {{ template "name" $ }}-role-binding
namespace: {{ . | quote }}
namespace: {{ . | trim }}
labels:
{{ include "labels" $ | indent 4 }}
roleRef:
kind: Role
name: {{ template "name" $ }}-role
apiGroup: rbac.authorization.k8s.io
namespace: {{ . | quote }}
namespace: {{ . | trim }}
subjects:
- kind: ServiceAccount
name: {{ template "serviceAccountName" $ }}
Expand Down

0 comments on commit 3c189ee

Please sign in to comment.