Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updown monitor support in Ingress Monitor Controller #152

Merged
merged 22 commits into from
Apr 15, 2019
Merged

updown monitor support in Ingress Monitor Controller #152

merged 22 commits into from
Apr 15, 2019

Conversation

aliartiza75
Copy link
Contributor

@aliartiza75 aliartiza75 commented Apr 5, 2019 •
edited

this PR resolves this issue #93

@softagram
Copy link

softagram bot commented Apr 5, 2019

Softagram Impact Report for pull/152 (head commit: 5e09602)

⭐ Change Overview

Showing the changed files, dependency changes and the impact - click for full size
(Open in Softagram Desktop for full details)

📄 Full report

Give feedback of this report to support@softagram.com

@stakater-user
Copy link
Contributor

@aliartiza75 Yikes! You better fix it before anyone else finds out! Build 1 has Failed!

@aliartiza75 aliartiza75 mentioned this pull request Apr 5, 2019
Closed
@aliartiza75
[updown-supprot-in-imc] implemented two method Setup and GetAll metho…
02b3855 
…d of updown monitor, added httpStatusCodesMap file that contains a map of status codes, delete test file for now and fixed typo in pingdom monior
@aliartiza75
Merge branch 'master' into updown-support-in-imc
d01d414
golangcibot
golangcibot reviewed Apr 8, 2019
View reviewed changes
pkg/monitors/updown/updown-monitor.go Outdated
updownService.apiKey = confProvider.ApiKey
updownService.alertContacts = confProvider.AlertContacts
// creating updown go client
httpDefaultClient := http.DefaultClient
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ineffectual assignment to httpDefaultClient (from ineffassign)

@stakater-user
Copy link
Contributor

@aliartiza75 Yikes! You better fix it before anyone else finds out! Build 2 has Failed!

@stakater-user
Copy link
Contributor

@aliartiza75 Yikes! You better fix it before anyone else finds out! Build 3 has Failed!

golangcibot
golangcibot reviewed Apr 8, 2019
View reviewed changes
pkg/monitors/updown/updown-monitor.go Outdated
// UpdownMonitorService struct contains parameters required by updown go client
type UpdownMonitorService struct {
apiKey string
url string
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

url is unused (from structcheck)

@stakater-user
Copy link
Contributor

@aliartiza75 Image is available for testing. docker pull stakater/ingressmonitorcontroller:SNAPSHOT-PR-152-4

@stakater-user
Copy link
Contributor

@aliartiza75 Yikes! You better fix it before anyone else finds out! Build 5 has Failed!

@stakater-user
Copy link
Contributor

@aliartiza75 Yikes! You better fix it before anyone else finds out! Build 6 has Failed!

@stakater-user
Copy link
Contributor

@aliartiza75 Yikes! You better fix it before anyone else finds out! Build 7 has Failed!

@stakater-user
Copy link
Contributor

@aliartiza75 Image is available for testing. docker pull stakater/ingressmonitorcontroller:SNAPSHOT-PR-152-8

@stakater-user
Copy link
Contributor

@aliartiza75 Image is available for testing. docker pull stakater/ingressmonitorcontroller:SNAPSHOT-PR-152-9

@stakater-user
Copy link
Contributor

@aliartiza75 Yikes! You better fix it before anyone else finds out! Build 10 has Failed!

@stakater-user
Copy link
Contributor

@aliartiza75 Yikes! You better fix it before anyone else finds out! Build 11 has Failed!

@stakater-user
Copy link
Contributor

@aliartiza75 Yikes! You better fix it before anyone else finds out! Build 12 has Failed!

@stakater-user
Copy link
Contributor

@aliartiza75 Yikes! You better fix it before anyone else finds out! Build 13 has Failed!

@stakater-user
Copy link
Contributor

@aliartiza75 Yikes! You better fix it before anyone else finds out! Build 14 has Failed!

@stakater-user
Copy link
Contributor

@aliartiza75 Yikes! You better fix it before anyone else finds out! Build 15 has Failed!

@stakater-user
Copy link
Contributor

@aliartiza75 Yikes! You better fix it before anyone else finds out! Build 16 has Failed!

@stakater-user
Copy link
Contributor

@aliartiza75 Yikes! You better fix it before anyone else finds out! Build 17 has Failed!

@aliartiza75
[updown-support-in-imc] pkg/monitors/uptimerobot/uptime-status-page_t…
19365af 
…est.go file updated by updating configs pull calls
@stakater-user
Copy link
Contributor

@aliartiza75 Yikes! You better fix it before anyone else finds out! Build 18 has Failed!

@stakater-user
Copy link
Contributor

@aliartiza75 Image is available for testing. docker pull stakater/ingressmonitorcontroller:SNAPSHOT-PR-152-19

@stakater-user
Copy link
Contributor

@aliartiza75 Image is available for testing. docker pull stakater/ingressmonitorcontroller:SNAPSHOT-PR-152-20

@aliartiza75 aliartiza75 self-assigned this Apr 12, 2019
@aliartiza75 aliartiza75 added the kind/enhancement New feature or request label Apr 12, 2019
@stakater-user
Copy link
Contributor

@aliartiza75 Image is available for testing. docker pull stakater/ingressmonitorcontroller:SNAPSHOT-PR-152-21

@kahootali kahootali merged commit 89b7243 into master Apr 15, 2019
@kahootali kahootali deleted the updown-support-in-imc branch April 15, 2019 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@golangcibot golangcibot golangcibot left review comments

@kahootali kahootali kahootali approved these changes

Assignees

@aliartiza75 aliartiza75

Labels
kind/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aliartiza75 @stakater-user @kahootali @golangcibot