Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helm chart for operator based implementation #315

Merged
merged 5 commits into from
May 3, 2021

Conversation

kahootali
Copy link
Contributor

@kahootali kahootali commented May 3, 2021

Closes #268

@stakater-user
Copy link
Contributor

@kahootali Image is available for testing. docker pull stakater/IngressMonitorController:SNAPSHOT-PR-315-ecd849e5

@kahootali
Copy link
Contributor Author

Somehow the Action Run didn't run the step I added in PR workflow

@ahmedwaleedmalik
Copy link
Contributor

ahmedwaleedmalik commented May 3, 2021

@kahootali Thanks for the contribution. It didn't work because in case of a PR it uses upstream pipelines instead of the pipelines defined in the PR. For security reasons, for more info:
https://docs.github.com/en/actions/reference/events-that-trigger-workflows#pull_request_target

@stakater-user
Copy link
Contributor

@kahootali Image is available for testing. docker pull stakater/IngressMonitorController:SNAPSHOT-PR-315-cc2a7f57

.github/workflows/pull_request.yml Outdated Show resolved Hide resolved
.github/workflows/push.yml Show resolved Hide resolved
deploy/chart/ingressmonitorcontroller/templates/role.yaml Outdated Show resolved Hide resolved
deploy/chart/ingressmonitorcontroller/values.yaml Outdated Show resolved Hide resolved
@stakater-user
Copy link
Contributor

@kahootali Image is available for testing. docker pull stakater/IngressMonitorController:SNAPSHOT-PR-315-8d430df8

Copy link
Contributor

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just few minor changes requested

.github/workflows/pull_request.yml Outdated Show resolved Hide resolved
deploy/chart/ingressmonitorcontroller/templates/role.yaml Outdated Show resolved Hide resolved
@stakater-user
Copy link
Contributor

@kahootali Yikes! You better fix it before anyone else finds out! Build has Failed!

@kahootali
Copy link
Contributor Author

The pipeline failed due to a failed test, can anyone from the team check or re-run the pipeline?

@stakater-user
Copy link
Contributor

@ahmedwaleedmalik Image is available for testing. docker pull stakater/IngressMonitorController:SNAPSHOT-PR-315-3c189eec

Copy link
Contributor

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahmedwaleedmalik ahmedwaleedmalik merged commit 6a6c858 into stakater:master May 3, 2021
@kahootali kahootali deleted the add-helm-chart branch May 3, 2021 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add helm chart for operator
3 participants