-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add helm chart for operator based implementation #315
Conversation
@kahootali Image is available for testing. |
Somehow the Action Run didn't run the step I added in PR workflow |
@kahootali Thanks for the contribution. It didn't work because in case of a PR it uses upstream pipelines instead of the pipelines defined in the PR. For security reasons, for more info: |
@kahootali Image is available for testing. |
deploy/chart/ingressmonitorcontroller/templates/clusterrole.yaml
Outdated
Show resolved
Hide resolved
@kahootali Image is available for testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just few minor changes requested
deploy/chart/ingressmonitorcontroller/templates/rolebinding.yaml
Outdated
Show resolved
Hide resolved
@kahootali Yikes! You better fix it before anyone else finds out! Build has Failed! |
The pipeline failed due to a failed test, can anyone from the team check or re-run the pipeline? |
@ahmedwaleedmalik Image is available for testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #268