Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reloader support for CronJobs #452

Open
ksudarsh00 opened this issue May 22, 2023 · 4 comments
Open

Reloader support for CronJobs #452

ksudarsh00 opened this issue May 22, 2023 · 4 comments
Labels
kind/enhancement New feature or request

Comments

@ksudarsh00
Copy link

Description:
Currently, reloader doesn't support CronJobs, so I have implemented support for Kubernetes CronJobs in the Stakater/Reloader repository and would like to contribute this feature back to the project.

Feature Implementation:
I have extended the functionality of Reloader to include support for Kubernetes CronJobs. With this enhancement, Reloader can now detect changes in ConfigMaps/Secrets and perform triggering a Job from an existing CronJob definition.

Steps to Reproduce:
To observe the added functionality, you can follow these steps:

Install Reloader in your Kubernetes cluster using the existing installation instructions.

Create a CronJob resource definition and add the annotations to watch for ConfigMaps/secrets.

Apply changes to the ConfigMap/Secrets resource such as modifying the data.

Verify that Reloader detects the changes and triggers a Job from the CronJob.

Code Contribution:
I have made the necessary modifications to the Reloader codebase to enable support for Kubernetes CronJobs. The changes include additions to the Reloader's resource detection logic and the implementation of triggering a Job from an existing CronJob.

I have thoroughly tested the feature, which works as expected in my company's pre-production environment.

I would happily contribute the code changes I've made to the Stakater/Reloader repository and collaborate with the maintainers to ensure proper integration.

If you think this feature is lacking and it's in your roadmap. Please let me know how I can proceed with this contribution.

@rasheedamir
Copy link
Member

Yes definitely @ksudarsh00! PRs are more than welcome

@karl-johan-grahn karl-johan-grahn added the kind/enhancement New feature or request label May 24, 2023
@kaiwalyajoshi
Copy link

Looking forward to this feature as well!

@andreyolv
Copy link

Amazing, exactly what I need. Is there any prediction of when they will merge this feature?

@RockyMM
Copy link

RockyMM commented Oct 5, 2023

Feature is available since #486

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants