Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCE] Allow to use auto annotation with specific resource type (configmap or secret) #582

Closed
kichel98 opened this issue Dec 6, 2023 · 4 comments · Fixed by #604
Closed
Labels
kind/enhancement New feature or request kind/help wanted Extra attention is needed

Comments

@kichel98
Copy link

kichel98 commented Dec 6, 2023

Is your feature request related to a problem? Please describe.
I am incorporating Reloader into my project mainly to automatically reload pods after certificates (secrets) change. For most deployments I do not want to allow reloading when configmaps change. But I would prefer not to forbid using Reloader for configmaps changes by setting ignoreConfigMaps globally (sometimes configmap reload might be used in my case). In this situation I need to use secret.reloader.stakater.com/reload: "<secret-list>" and maintain the <secret-list>. It would be much easier if I could use auto annotation for a given deployment/statefulset/daemonset but only for secrets.

Describe the solution you'd like
Please enhance auto annotation and in addition to reloader.stakater.com/auto: "true" allow more specific annotations which allow to
filter watched resources by resource type: configmap.reloader.stakater.com/auto: "true" and secret.reloader.stakater.com/auto: "true". E.g. using secret.reloader.stakater.com/auto: "true" will lead to the same behaviour as reloader.stakater.com/auto: "true" but only for mounted secrets, ignoring configmaps.

If you see other options to achieve what I need, please share.

@kichel98 kichel98 added the kind/enhancement New feature or request label Dec 6, 2023
@MuneebAijaz MuneebAijaz added the kind/help wanted Extra attention is needed label Dec 13, 2023
@MuneebAijaz
Copy link
Contributor

@kichel98 if you'd like to submit a pull request for this change, we welcome the change

kichel98 pushed a commit to kichel98/Reloader that referenced this issue Jan 19, 2024
kichel98 pushed a commit to kichel98/Reloader that referenced this issue Jan 19, 2024
@kichel98
Copy link
Author

kichel98 commented Jan 19, 2024

@MuneebAijaz Here it is: #604 😄

@pikopl
Copy link

pikopl commented Jan 22, 2024

+1

MuneebAijaz added a commit that referenced this issue Apr 8, 2024
…resource-type-squashed

[#582] Allow to use auto annotation with specific resource type (configmap or secret)
@MuneebAijaz
Copy link
Contributor

closing in favour of #604

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request kind/help wanted Extra attention is needed
Projects
None yet
3 participants