Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reloader broken with Kubernetes 1.16 #105

Closed
Neraud opened this issue Oct 15, 2019 · 2 comments · Fixed by #106
Closed

Reloader broken with Kubernetes 1.16 #105

Neraud opened this issue Oct 15, 2019 · 2 comments · Fixed by #106

Comments

@Neraud
Copy link

Neraud commented Oct 15, 2019

After deploying Reloader on an on-prem Kubernetes 1.16 cluster, I've seen many logs like :
Failed to list [kind] the server could not find the requested resource

I've reproduced the issue on a more simple and controlled minikube setup.

Using minikube 1.3.1 (with Kubernetes 1.15), it works fine.
Using minikube 1.4.0 (with Kubernetes 1.16), it produces the same error.

Manifests are available there to reproduce if needed.

I assume it's linked to deprecations in Kubernetes 1.16 : see https://kubernetes.io/blog/2019/07/18/api-deprecations-in-1-16/

DaemonSet, Deployment, StatefulSet, and ReplicaSet (in the extensions/v1beta1 and apps/v1beta2 API groups)
Migrate to use the apps/v1 API, available since v1.9. Existing persisted data can be retrieved/updated via the apps/v1 API.

And I guess to fix it you would have to (at least) change clients.KubernetesClient.ExtensionsV1beta1().[Kind] in https://github.com/stakater/Reloader/blob/master/internal/pkg/callbacks/rolling_upgrade.go

@waseem-h
Copy link
Contributor

Thanks for pointing it out @Neraud. I have plans to fix this soon

@waseem-h
Copy link
Contributor

@Neraud Making reloader compatible with 1.16 is underway in #106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants