Improvements to the portal #3
Conversation
Replace "Burned NFTs" with another stat in the NFTs list of collections. Add favicon Replace SCPscan with logo in Navbar Show table with all downloads below the auto detection Move Dark/Light mode switch button to right in navbar
|
|
||
| if (nftsSold > 0){ | ||
| domTotalBurnsTxt.innerText = 'Total sold in the Marketplace'; |
There was a problem hiding this comment.
Why are the variables not re-named?
There was a problem hiding this comment.
If you are referring to domTotalBurnsTxt, the name is always the same because the id of the container div always remains the same
|
|
||
| function getInfoCollection(){ | ||
| $.getJSON('https://stakecube.io/api/v2/marketplace/collection?contract=' + id, function(res) { |
There was a problem hiding this comment.
Tbh, im not sure about this one in general. I would vote against pulling stats from a centralized third party. This makes SCPscan depending on others (even its from the same Devs) and one advantage is, SCPscan can run standalone
cc @JSKitty
There was a problem hiding this comment.
We can find other values to display if there are no NFTs burned in the collection. However, if the marketplace API were no longer functional, those values would not be entered.
There was a problem hiding this comment.
I think it's fine to display some centralized info if it is non-mandatory data, like the Verification data is pulled for the Collections ranking, but if the request fails, the site will just fallback to other data, it won't break, a similar method here would be awesome.
There was a problem hiding this comment.
I left an in-line code review, and have two more reviews below for bugs that I don't know the origin of:
In the Download page: Sometimes executables will be tagged as "signatures", the v1.1.7 release binary was tagged as a signature, but the v1.1.6 release was tagged correctly.
And in the home page (Tokens), clicking on "Total Users" will popup a very dark overlay, and then the page becomes unusable: I cannot click anything without refreshing the page, seems to be some CSS issue caused by this PR.
Other than these issues, the PR seems great: the download page is awesome, logo looks nice on all pages, etc.
Changed image ico Fixed modal problem Fixed the recognition of the file type on the downloads page
|
@JSKitty I have made the required corrections |
|
Perfect! All issues were fully corrected, I've tested all. 😄 |
Add a basic system for "verified coin profiles", e.g; social links, website, etc.
Add 'open full image' button / clickable image to the NFT Details view.
Replace "Burned NFTs" with total sales on the SC Marketplace.
Add favicon
Replace SCPscan with logo in Navbar
Show table with all downloads below the auto detection
Move Dark/Light mode switch button to right in navbar