-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/cache integration #639
Conversation
Cool @tobi-bams ! I don't see how the test can work, if you don't add "preview" to the tribe. Next, we need a separate route to set the "preview" field in a tribe. The main relay config can have a The |
@Evanfeenstra, I was able to do some manipulation on my local machine to add the preview to the tribe and the test did pass. I will also create the route that stores the preview, My concern so far is how do we tend to validate the preview |
Good point. When you add the |
Yes, it makes sense!!! |
@tobi-bams I removed the DEFAULT_CACHE_HOST for now, i want to make sure it works 100% before merging anything that could make existing tribes miss messages The last step is to add |
Alright... |
|
…dmins when previe is set
…without preview set
Great. Tomorrow can you try all the tribe tests with |
@Evanfeenstra fields that are not present in cache object
|
…che for getmessages
last thing @omoniyi24 add If that is set then the tribe tests run |
Cache integration added to relay