Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix essentially all remaining typoes #22

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

darthwalsh
Copy link
Contributor

@darthwalsh darthwalsh commented Apr 6, 2024

(For context, see the diff online.)

I scrolled through all pages of the PDF looking for all remaining typos.

The change I'm least sure of: In docs/vi.c.1-ilasm-keywords.md creating a markdown table without a header isn't supported in github flavored markdown: https://stackoverflow.com/a/26398232/771768

  • Most of the fixes are words with - at the end of a line
    • PDF readers ignore the hyphen as if it is a split word i.e. "codepoint"
    • but the rest of ECMA-335 prefers the hyphenated words i.e. "code-point"
  • fixed a lot of markdown _ not rendering right on github.
  • fix | in a table not being escaped.

As an FYI, I noticed 2 links being to different targets that are more specific, but these are not in the PR as they seemed like intentional fixes and not typos:

i.12.4-control-flow.md
- 2. Control transfer out of a protected region is covered in §[I.12.4.2.3](i.12.4.2.3-resolution-exceptions.md).
+ 2. Control transfer out of a protected region is covered in §[I.12.4.2](i.12.4.2-exception-handling.md).

ii.22.26-methoddef-0x06.md
- * _ImplFlags_ (a 2-byte bitmask of type _MethodImplAttributes_, §[II.23.1.11](ii.23.1.11-flags-for-methods-methodimplattributes.md))
+ * _ImplFlags_ (a 2-byte bitmask of type _MethodImplAttributes_, §[II.23.1.10](ii.23.1.10-flags-for-methods-methodattributes.md))

In docs\vi.c.1-ilasm-keywords.md creating a markdown table without a header isn't supported in github flavored markdown: https://stackoverflow.com/a/26398232/771768

Didn't apply these changes to linked sections, as they seemed like intentional improvements and not mistakes:
```
i.12.4-control-flow.md
- 2. Control transfer out of a protected region is covered in §[I.12.4.2.3](i.12.4.2.3-resolution-exceptions.md).
+ 2. Control transfer out of a protected region is covered in §[I.12.4.2](i.12.4.2-exception-handling.md).

ii.22.26-methoddef-0x06.md
- * _ImplFlags_ (a 2-byte bitmask of type _MethodImplAttributes_, §[II.23.1.11](ii.23.1.11-flags-for-methods-methodimplattributes.md))
+ * _ImplFlags_ (a 2-byte bitmask of type _MethodImplAttributes_, §[II.23.1.10](ii.23.1.10-flags-for-methods-methodattributes.md))
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant