Implement IFluidHandlerItem capability for EdelwoodBucketItem #377
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full disclosure that I am trying to get into Minecraft modding by fixing issues on existing mods, so feedback is very much appreciated.
I took a look at this issue that talked about cross mod compatibility and the edelwood bucket. I determined the root issue to be that edelwood bucket inherits the capabilities of its parent which don't work correctly for it. So here is an implementation of the IFluidHandlerItem for the edelwood bucket.
I modeled the bucket as having two internal tanks, one for water and one for lava. This allowed properly receiving different quantities of the two fluids instead of having one max capacity. Additionally, once on of the tanks has any liquid, the other will not take any.