This repository has been archived by the owner on Apr 21, 2023. It is now read-only.
Translating tutorial page #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RStankov
reviewed
Feb 19, 2019
| href: /tutorial/tutorial.html#picking-a-key | ||
| forceInternal: true | ||
| - id: implementing-time-travel | ||
| title: Implementing Time Travel | ||
| title: Имплементиране на пътуване във времето |
There was a problem hiding this comment.
I'm wondering if "пътуване във времето" should be "Time travel" since it is industry term
jumpalottahigh
suggested changes
Feb 19, 2019
content/tutorial/nav.yml
Outdated
| href: /tutorial/tutorial.html#why-immutability-is-important | ||
| forceInternal: true | ||
| - id: function-components | ||
| title: Function Components | ||
| title: Функционален компонент |
There was a problem hiding this comment.
Функционален = Functional, and as such it worries me because it contains double meaning. E.g., Class components are also functional in a sense that they have a function to do something. Maybe something else along the lines of: "Компонент от/чрез функция", although it sounds a bit weird but a bit more clear. Just an idea, not the end of the world, I leave it up to your call :)
There was a problem hiding this comment.
Good point. I read somewhere "Function component". What you think about "Функция компонент"? e2c3756
jumpalottahigh
approved these changes
Feb 20, 2019
88 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.