Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

Finish translating composition vs inheritance #28

Merged
merged 3 commits into from Jun 20, 2019
Merged

Finish translating composition vs inheritance #28

merged 3 commits into from Jun 20, 2019

Conversation

shakib609
Copy link
Contributor

No description provided.

@tesseralis tesseralis mentioned this pull request Apr 28, 2019
Closed
88 tasks
@netlify
Copy link

netlify bot commented Apr 28, 2019 •
edited

Deploy preview for bn-reactjs ready!

Built with commit 56e83e2

https://deploy-preview-28--bn-reactjs.netlify.com

@shakib609 shakib609 requested a review from nutboltu June 10, 2019 19:30
nutboltu
nutboltu reviewed Jun 17, 2019
View reviewed changes
content/docs/composition-vs-inheritance.md Outdated Show resolved Hide resolved
content/docs/composition-vs-inheritance.md Outdated Show resolved Hide resolved
content/docs/composition-vs-inheritance.md Outdated Show resolved Hide resolved
content/docs/composition-vs-inheritance.md Outdated Show resolved Hide resolved
nutboltu
nutboltu approved these changes Jun 19, 2019
View reviewed changes
Copy link
Contributor

@nutboltu nutboltu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! @shakib609

বেশ ভাল হয়েছে 🇧🇩

@nutboltu
Copy link
Contributor

@shakib609 Can you please fix the build so that we can merge it

@shakib609
Copy link
Contributor Author

shakib609 commented Jun 20, 2019 •
edited

@nutboltu I checked the test logs. It seems like some packages could not be fetched from yarn. That's why the tests did not pass.

11:28:54 PM: error An unexpected error occurred: "https://registry.yarnpkg.com/estraverse/-/estraverse-4.2.0.tgz: ETIMEDOUT".
11:28:54 PM: failed during stage 'building site': Build script returned non-zero exit code: 1
11:28:54 PM: info If you think this is a bug, please open a bug report with the information provided in "/opt/build/repo/yarn-error.log".

I tried re-running the test but it is not working. Should I make a small commit to trigger the build?

@nutboltu
Copy link
Contributor

Let's make a small commit. if it doesn't work we can open a new PR

@shakib609 shakib609 merged commit 13b52df into stale-reactjs-org-translations:master Jun 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nutboltu nutboltu nutboltu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shakib609 @nutboltu