Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

Rendering Elements #77

Conversation

tamzidkarim
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented May 21, 2020

Deploy preview for bn-reactjs ready!

Built with commit 6d32af6

https://deploy-preview-77--bn-reactjs.netlify.app

content/docs/rendering-elements.md Outdated Show resolved Hide resolved
content/docs/rendering-elements.md Outdated Show resolved Hide resolved
content/docs/rendering-elements.md Outdated Show resolved Hide resolved
content/docs/rendering-elements.md Outdated Show resolved Hide resolved
content/docs/rendering-elements.md Outdated Show resolved Hide resolved
content/docs/rendering-elements.md Outdated Show resolved Hide resolved
Copy link
Contributor Author

@tamzidkarim tamzidkarim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed suggestions

content/docs/rendering-elements.md Outdated Show resolved Hide resolved
content/docs/rendering-elements.md Outdated Show resolved Hide resolved
@tesseralis tesseralis mentioned this pull request May 22, 2020
88 tasks
Copy link
Contributor

@shakib609 shakib609 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. ✌️
Great work @tamzidkarim

@shakib609
Copy link
Contributor

@nutboltu vai can you also do a quick check? In case, I missed something.

@@ -10,7 +10,7 @@ There are many example projects created by the React community. We're keeping th

If you add a project, please commit to keeping it up to date with the latest versions of React.

## Small Examples
## Small Examples {#small-examples}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tamzidkarim any reason behind these changes in this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly I dont have any idea how this file got changed. So thats why i kept it that way. Now that you mentioned it I guess I will unchange this file.


```js
const element = <h1>Hello, world</h1>;
const element = <h1>হ্যালো, ওয়ার্ল্ড</h1>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry that was my mistake that I did in the Home Page. But let's not translate code snippet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem.

Copy link
Contributor

@nutboltu nutboltu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! @tamzidkarim 🎉

@nutboltu nutboltu merged commit f2ceea2 into stale-reactjs-org-translations:master May 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants