Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

rendering-elements translations #5

Merged

Conversation

sonipreshita
Copy link
Contributor

Translated Rendering-Elements page of the Docs section to Gujarati.

@tesseralis tesseralis mentioned this pull request Mar 8, 2019
88 tasks
@sonipreshita sonipreshita changed the title rendering-elements translations rendering-elements translations #5 Mar 11, 2019
@sonipreshita sonipreshita changed the title rendering-elements translations #5 rendering-elements translations Mar 11, 2019

React elements are [immutable](https://en.wikipedia.org/wiki/Immutable_object). Once you create an element, you can't change its children or attributes. An element is like a single frame in a movie: it represents the UI at a certain point in time.
React elements [અવ્યવસ્થિત](https://en.wikipedia.org/wiki/Immutable_object) છે. એકવાર તમે element બનાવી લો, પછી તમે તેના children અથવા attributes ને બદલી શકતા નથી. એક element મૂવીમાં એક ફ્રેમ જેવું છે: તે ચોક્કસ સમયે UI રજૂ કરે છે.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

અવ્યવસ્થિત is not a correct word, it should be અપરિવર્તીત

@sonipreshita
Copy link
Contributor Author

sonipreshita commented Mar 13, 2019 via email

@3sanket3
Copy link
Contributor

@sonipreshita can you please use yarn to install the dependencies?

It seems you used npm, due to which it added package-lock.json. We already have equivalent yarn.lock , so we should not commit the package-lock.json.

If you haven't set up yarn anytime, https://yarnpkg.com/en/docs/install should help. Let me know if any issue.

For this PR, please delete the package-lock.json file and push the changes.

@ron4ex
Copy link
Contributor

ron4ex commented Mar 14, 2019

Or if you don't want to use yarn, just don't commit the file in the pull request changes. Commit only the ones that are relevant.

@sonipreshita
Copy link
Contributor Author

@ron4ex
I have committed changes and removed a package-lock.json file from the PR. Check this and let me know.

@tesseralis
Copy link
Contributor

tesseralis commented Mar 28, 2019

@RupenAnjaria @3sanket3 I think this might be ready for another review?

@3sanket3
Copy link
Contributor

@tesseralis Yes it is and I am reviewing the same.

We were little confused as we decided initially to translate 'Hello World' in native Gujarati but then we found at many places the documentation directly pulls code from the .js files where the code is obviously written in English. Also, referred other translation repositories and finally thinking to keep 'Hello World' as it is. We will also update the same thing in other translated pages as well.

@3sanket3 3sanket3 mentioned this pull request Mar 31, 2019
@3sanket3 3sanket3 merged commit 177efbc into stale-reactjs-org-translations:master Mar 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants