Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

RTL support for Urdu version #6

Merged
merged 2 commits into from May 15, 2019

Conversation

mumairofficial
Copy link
Contributor

@mumairofficial mumairofficial commented May 12, 2019

Description

RTL Support for Urdu language #4

Updated the links in README.md

Previews:

image

image

image

image

@mumairofficial mumairofficial changed the title Updates in readme file RTL support for Urdu version May 12, 2019
@jabranr jabranr self-assigned this May 13, 2019
Copy link
Contributor

@jabranr jabranr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. Do you think it would be a good candidate for until we have some Urdu content in? I am just thinking from point of view that it might make it difficult for users to update content from a language which is not RTL?

@jabranr
Copy link
Contributor

jabranr commented May 13, 2019

@mumairofficial also do you want to adhere to the branching guidelines given here - https://github.com/reactjs/ur.reactjs.org#create-a-branch

@mumairofficial
Copy link
Contributor Author

Hi @jabranr,

Answer to first question: I have went through all possible pages after RTL conversion and could not found any problem, code snippets are LTR.

In this repository all the content would be Urdu language specific, so there should not be any difficulty while updating the content in .md files

I have noted the branching recommendation and my future contributions would be in feature branch.

@jabranr
Copy link
Contributor

jabranr commented May 15, 2019

@mumairofficial makes sense. Will move it forward.

@jabranr jabranr added the ready to merge Work approved code review and ready to release label May 15, 2019
@jabranr jabranr merged commit d848779 into stale-reactjs-org-translations:master May 15, 2019
@jabranr jabranr added released Work merged into master and removed ready to merge Work approved code review and ready to release labels May 15, 2019
@jabranr jabranr mentioned this pull request May 16, 2019
89 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
released Work merged into master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants