Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed deprecated properties and methods #355

Closed
stalniy opened this issue Jul 16, 2020 · 0 comments
Closed

Removed deprecated properties and methods #355

stalniy opened this issue Jul 16, 2020 · 0 comments
Labels
breaking change maintenance
Milestone
v5

Comments

@stalniy
Copy link
Owner

stalniy commented Jul 16, 2020 •
edited

There are several deprecated properties which needs to be removed in v5:

  • AbilityOptions.subjectName
  • LegacyClaimRawRule & LegacySubjectRawRule
  • Rule.actions
  • error when there is a rule with fields being an empty array
  • remove isAllInverted warning
@stalniy stalniy added this to the v5 milestone Jul 16, 2020
stalniy added a commit that referenced this issue Jul 16, 2020
@stalniy
refactor(ability): removes deprecated types and fields
cc7091e 
Removes `RuleAnalyzer` and moves its logic under `Rule` and `RuleIndex`
Relates to #355

BREAKING CHANGE: removes deprecated options and types:

* `AbilityOptions['subjectName']` has been removed, use `detectSubjectType` instead
* `LegacyClaimRawRule` and `LegacySubjectRawRule` are both removed, so you are no longer allowed to use `actions` in rule definition, use `action` property instead
* `Ability` throws an error if you specify a rule with property `field` to be an empty array
* `Ability` no longer warns about using only inverted rules. This may be done by intention, so now it's left up to developer to decide whether it's fine or not
@stalniy stalniy closed this as completed Jul 16, 2020
stalniy added a commit that referenced this issue Aug 6, 2020
@stalniy
refactor(ability): removes deprecated types and fields
bf5ef73 
Removes `RuleAnalyzer` and moves its logic under `Rule` and `RuleIndex`
Relates to #355

BREAKING CHANGE: removes deprecated options and types:

* `AbilityOptions['subjectName']` has been removed, use `detectSubjectType` instead
* `LegacyClaimRawRule` and `LegacySubjectRawRule` are both removed, so you are no longer allowed to use `actions` in rule definition, use `action` property instead
* `Ability` throws an error if you specify a rule with property `field` to be an empty array
* `Ability` no longer warns about using only inverted rules. This may be done by intention, so now it's left up to developer to decide whether it's fine or not
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change maintenance
Projects
None yet
Milestone
v5
Development

No branches or pull requests
1 participant
@stalniy