Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for RxJS 7.0 and Angular 13 #580

Closed
wants to merge 7 commits into from

Conversation

jochenjonc
Copy link

Upgrade of the peerDependecies to be able to support Angular 13 and RxJS 7.

I looked at the peerDependecies used by Angular in their repo, https://github.com/angular/components/blob/12.2.x/packages.bzl.

I hope this change is enough, I'm not familiar with pnmn and did not succeed in building the project on my machine.

"@casl/ability": "^3.0.0 || ^4.0.0 || ^5.1.0",
"rxjs": "^6.5.3",
"rxjs": "^6.5.3 || ^7.0.0",
"tslib": "^2.0.0"
},
"devDependencies": {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in devDependencies you need to update rxjs, so then when test pass I will know it uses the correct version of rxjs

@@ -46,9 +46,9 @@
"author": "Sergii Stotskyi <sergiy.stotskiy@gmail.com>",
"license": "MIT",
"peerDependencies": {
"@angular/core": "^12.0.0",
"@angular/core": "^12.0.0 || ^13.0.0-0",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure it works properly with Angular v13. You need to update dev deps angular version to ensure that it's true

@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2021

Codecov Report

Merging #580 (397b88f) into master (9f91ac4) will decrease coverage by 0.21%.
The diff coverage is 91.89%.

❗ Current head 397b88f differs from pull request most recent head 393cf34. Consider uploading reports for the commit 393cf34 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #580      +/-   ##
==========================================
- Coverage   93.95%   93.74%   -0.22%     
==========================================
  Files          32       32              
  Lines         711      719       +8     
  Branches      167      174       +7     
==========================================
+ Hits          668      674       +6     
- Misses         12       13       +1     
- Partials       31       32       +1     
Impacted Files Coverage Δ
...ckages/casl-prisma/src/prisma/PrismaQueryParser.ts 93.84% <75.00%> (-1.07%) ⬇️
packages/casl-mongoose/src/accessible_records.ts 80.00% <88.88%> (-5.19%) ⬇️
packages/casl-ability/src/utils.ts 95.23% <91.30%> (-0.82%) ⬇️
packages/casl-ability/src/RuleIndex.ts 94.87% <95.23%> (+0.42%) ⬆️
packages/casl-ability/src/structures/LinkedItem.ts 100.00% <100.00%> (ø)
packages/casl-angular/src/AbilityModule.ts 100.00% <100.00%> (ø)
packages/casl-angular/src/pipes.ts 100.00% <100.00%> (+4.16%) ⬆️
packages/casl-mongoose/src/accessible_fields.ts 95.23% <100.00%> (ø)
packages/casl-mongoose/src/mongo.ts 100.00% <100.00%> (ø)
...ges/casl-prisma/src/prisma/interpretPrismaQuery.ts 97.61% <100.00%> (-0.11%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9c5be5...393cf34. Read the comment docs.

@jochenjonc
Copy link
Author

@stalniy can you have a look at the failing test? I'm a bit stuck on it.

@stalniy
Copy link
Owner

stalniy commented Dec 23, 2021

I’ll take a look tomorrow

@b-johnse
Copy link

bump

@stalniy
Copy link
Owner

stalniy commented Apr 22, 2022

Tests are not passing. Additionally I’d like somebody to check that this casl example works properly with rxjs 7, angular 13 and updated version of casl

I don’t have laptop right now and will not have one for the next few weeks. We have a war in Ukraine and sadly… my family was shelled. currently casl is the smallest of my problems.

So, go ahead and do extra work

@b-johnse
Copy link

@stalniy I hope you are doing okay!
I'm using in production with ng13.3 and rxjs 7.5.5 by using --legacy-peer-deps when i npm i so no functional change is required

@jochenjonc if you need I can try taking a look at this to get tests passing

@stalniy
Copy link
Owner

stalniy commented Jun 14, 2022

close in favor of #632

@stalniy stalniy closed this Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants