Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oleg is biking the wrong route #6

Closed
jevakallio opened this issue Mar 20, 2015 · 13 comments · Fixed by #8
Closed

Oleg is biking the wrong route #6

jevakallio opened this issue Mar 20, 2015 · 13 comments · Fixed by #8

Comments

@jevakallio
Copy link

The video shows Oleg going by the Hietaniemi cemetery, but the route on the map goes down Porkkalankatu and through the center.

How do I submit a pull request that will make @phadej reshoot the video? :trollface:

@phadej
Copy link
Contributor

phadej commented Mar 20, 2015

@jevakallio you cannot, Helsinki used its sunny days quota :trollface:

@staltz
Copy link
Owner

staltz commented Mar 20, 2015

I agree with @jevakallio. But before @phadej 's PR we need an automated test case for this.

@jsunfutu
Copy link

Can't you change the route on the map to go through the cemetery?

@jevakallio
Copy link
Author

@jsunfutu no

@jevakallio
Copy link
Author

@staltz how about we scatter broken glass and install trip wires on all the routes we don't want him to take, effectively guaranteeing that if the packet reaches target it will have had to move through the correct switches?

@miro
Copy link
Contributor

miro commented Mar 20, 2015

Trying to reproduce and fix this on my local environment, what is the exact model of the bicycle?

@staltz
Copy link
Owner

staltz commented Mar 20, 2015

Yes, but let's make that a separate library so we don't clutter this. I suggest bikehint would be the name.

@staltz
Copy link
Owner

staltz commented Mar 20, 2015

@phadej what's your bicycle's exact model?

@phadej
Copy link
Contributor

phadej commented Mar 20, 2015

@miro @staltz Pelago San Sebastian, but there is a problem:

  • I have done few local patches
  • which are applied on two year old upstream version
  • Luckily, I'm pretty sure you can apply patches to the newest version too; did some refactoring recently.

@staltz
Copy link
Owner

staltz commented Mar 20, 2015

Nothing that docker won't solve. You have it in docker, right?

@phadej
Copy link
Contributor

phadej commented Mar 20, 2015

I think there might be some problems with DRM :S bycycles are tricky

@kpuputti
Copy link

Posting in epic thread

@daniellandau
Copy link

Tangentially relevant: http://en.wikipedia.org/wiki/IP_over_Avian_Carriers

jvah pushed a commit to jvah/annankatu that referenced this issue Mar 20, 2015
We love green values, also fixes staltz#6.
jvah added a commit to jvah/annankatu that referenced this issue Mar 20, 2015
We love green values, also fixes staltz#6.
@staltz staltz closed this as completed in #8 Mar 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants