Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.3.2 breaks merge()? #103

Closed
svachalek opened this issue Aug 15, 2016 · 4 comments
Closed

5.3.2 breaks merge()? #103

svachalek opened this issue Aug 15, 2016 · 4 comments

Comments

@svachalek
Copy link

I haven't been able to narrow it down further (will try) but there was a breaking change in 5.3.2. A stream that is using merge() operates as expected in 5.3.1 but in 5.3.2 and 5.3.3, output on the first stream (of 3) that is merged will trigger a state where output on the 2nd and 3rd streams does not produce anything on the merge(). (That is, a debug() spy on the input stream is showing activity while one on the merged stream does not.)

@svachalek
Copy link
Author

(Also note I did try adding replaceError to the merge to see if an exception was being thrown, but it is not triggered.)

staltz added a commit that referenced this issue Aug 15, 2016
Reverts the change done in commit 819bc94, which is problematic due
to issue #104. This commit here will fix issues like #103 and similar. It reverts xstream's behavior
back to what it was in v5.3.1.

Closes issue #103.
@staltz
Copy link
Owner

staltz commented Aug 15, 2016

@svachalek can you try with xstream v5.3.4?

@svachalek
Copy link
Author

Works for me! Thanks for the quick turnaround.

@staltz
Copy link
Owner

staltz commented Aug 15, 2016

If you want to see why this happened, read #104.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants