Made more fields public + added get_canonicalized_header function to authenticated_message #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_canonicalized_header is useful for getting the pre-hashed, canonically ordered DKIM headers.
I also made some struct fields public: perhaps making them public leads to unintended access patterns, but since they are non-mutable and potentially useful for users to parse out DKIM info, I thought it would be useful to keep in the PR (and I personally am writing code that requires accessing those fields, but I am happy to revert them as well).
This is my first OSS Rust crate PR, so let me know if there are any PR details that I missed, docs/examples I should edit, or things I should change!