Message::parse() panics!

[arifd]

Hi guys,

Great little library!! But...

This example:

use mail_parser::Message;

const INPUT: &[u8; 314] = br#"From: <redacted@flashmail.net>
Subject: Redacted
To: <redacted@Enron.com>
Message-ID: <105647271315.NCV17523@x263.net>
MIME-version: 1.0
Content-Type: text/html;
 charset=utf-8
Content-Disposition: =?utf-8?Q?invalid?=
Content-Transfer-Encoding: quoted-printable
Content-Disposition: =?utf-8?Q?invalid?=

<p>foo</p>"#;

fn main() {
    let message = Message::parse(INPUT);
    dbg!(message);
}

Will panic with this message:

thread 'main' panicked at 'HeaderValue::get_content_type called on non-ContentType value', /home/arif/.cargo/registry/src/github.com-1ecc6299db9ec823/mail-parser-0.4.4/src/lib.rs:693:18

despite Message::parse advertising it never will; and that it does a best effort.

Could we have a look into it? Thanks!

[mdecimus]

Hi, that was actually a bug, thanks for the report! I've just committed the fix to the repository, please could you give it a try?

[arifd]

confirmed! Thank you!

[arifd]

hey @mdecimus, been waiting for an update on crates.io You don't think the bugfix is worth the PATCH version update, as outlined by https://semver.org/?

[mdecimus]

You are correct but I was waiting to add other fixes/enhancements before pushing a patch to crates.io. Anyway, this week I am going to implement #13 and release a new patch version update. I'll keep you posted!

[mdecimus]

@arifd Hi, v0.4.5 including this fix is now on crates.io.

[arifd]

Thank you! Incredibly responsive!!