Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove org. from modestmaps #26

Closed
tmcw opened this issue May 3, 2011 · 5 comments
Closed

Remove org. from modestmaps #26

tmcw opened this issue May 3, 2011 · 5 comments
Milestone

Comments

@tmcw
Copy link
Contributor

tmcw commented May 3, 2011

Okay, this one's up for debate, it's just something that's been bugging me:

The com.modestmaps convention in this naming (which polymaps inherited), seems to be a narrowly Flash (and I suppose Java) idiom, not seem elsewhere in Javascript. Could the library eventually move to simply modestmaps?

@RandomEtc
Copy link
Contributor

I'd consider aliasing it routinely in your app and see what sticks. e.g. I regularly do var MM = com.modestmaps in my app code. Sometimes I even copy all the com.modestmaps members to window with a quick for-in loop.

There needs to be something because e.g. Point, Location, Coordinate, Transformation, Projection and Map are all too generic for Modest Maps to claim in the global namespace. Is MM rare enough?

But yeah it could go away harmlessly - we could even make a com.modestmaps alias of whatever we choose.

@tmcw
Copy link
Contributor Author

tmcw commented May 5, 2011

I think MM sounds good. I checked out the source to $.noConflict and it looks unobtrusive enough (albeit reliant on the browser... we'd have to improve that) that we could go for a concise namespace and never totally clobber other tools that take MM.

@RandomEtc
Copy link
Contributor

Underscore has a similar feature, it's a tiny function and just a
matter of saving the previous MM before creating your own.

On 5 May 2011 16:56, tmcw
reply@reply.github.com
wrote:

I think MM sounds good. I checked out the source to $.noConflict and it looks unobtrusive enough (albeit reliant on the browser... we'd have to improve that) that we could go for a concise namespace and never totally clobber other tools that take MM.

Reply to this email directly or view it on GitHub:
#26 (comment)

@migurski
Copy link
Contributor

migurski commented May 6, 2011

+1 for MM as well - it's concise and it's what I end up actually using all the time anyway.

@tmcw
Copy link
Contributor Author

tmcw commented Dec 7, 2011

Fixed in a905543

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants