Infrastructure update. #235
Conversation
Use latest ESLint, Babel, Rollup. Rename distr. bundle files to avoid common confusions.
|
Oops! ESLint v3 dropped support of node 0.12. |
|
I thought we already agreed on dropping support for 0.12. You even made issue for it :) #224 |
|
I admire your memory! Dropping it now (because I dropped only the 0.10). :) |
| "rules": { | ||
| "object-curly-spacing": [2, "never"], | ||
| "no-param-reassign": 0, | ||
| "comma-dangle": 0, | ||
| "no-confusing-arrow": 0, | ||
| "prefer-rest-params": 0, | ||
| "no-use-before-define": 1 | ||
| "no-use-before-define": 1, | ||
| "no-plusplus": 0 |
There was a problem hiding this comment.
Is it really necessary to disable this rule for a whole project? I see only occurrence in test file, you can either disable there or I simply prefer to use counter += 1. The ++ operator just looks weird.
There was a problem hiding this comment.
Scratch that only occurrence, it's also in some for loops. But still I don't like that operator :)
| @@ -6,7 +6,7 @@ | |||
| "name": "Eric Elliott", | |||
| "url": "https://ericelliottjs.com" | |||
| }, | |||
| "main": "dist/stampit.js", | |||
| "main": "dist/stampit.full.js", | |||
| "jsnext:main": "dist/stampit.mjs", | |||
| "browser": "dist/stampit.es5.js", | |||
There was a problem hiding this comment.
Should be stampit.umd.js if I am not mistaken...
|
It took me a while to find it, I only vaguely knew, we talked about it. |
Use latest ESLint, Babel, Rollup.
Rename distr. bundle files to avoid common confusions.