Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next release #136

Closed
jgabry opened this issue Mar 26, 2018 · 5 comments
Closed

next release #136

jgabry opened this issue Mar 26, 2018 · 5 comments

Comments

@jgabry
Copy link
Member

jgabry commented Mar 26, 2018

@tjmahr I'd like to release the loo update stuff since we'll be releasing a new version of the loo package asap. We've also got a bunch of other things waiting so probably a good time to get something out anyway. Do I need to do anything with the ppc_data function that's on the master branch? Is that intended for/ready for release? Or do we need to remove that code before releasing from master branch?

@tjmahr
Copy link
Collaborator

tjmahr commented Mar 27, 2018

I'll double-check that code in the next couple days.

@jgabry
Copy link
Member Author

jgabry commented Mar 27, 2018 via email

@tjmahr
Copy link
Collaborator

tjmahr commented Mar 29, 2018

I think the code should be okay, based on tests in #137.

@jgabry
Copy link
Member Author

jgabry commented Mar 29, 2018

Ok great, thanks! I'll go ahead and get the release submitted.

@jgabry
Copy link
Member Author

jgabry commented Mar 29, 2018

closing after submitting version 1.5.0. I'll tag a release when accepted.

@jgabry jgabry closed this as completed Mar 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants