Update for new ggplot2 release #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the heads up and the pull request! |
|
These changes look good and everything is passing for me locally (using both the current ggplot2 and the release candidate). The GHA failures are unrelated so I will go ahead and merge this. Thanks again! |
jgabry
approved these changes
Jan 17, 2024
|
Thanks for the swift response! |
|
I just submitted the bayesplot update to CRAN. If there are no issues (and I didn't find any issues checking reverse dependencies) then it should be on CRAN in plenty of time to avoid anything breaking with the ggplot2 release. |
|
Great, thanks for checking in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there,
We have been preparing a new release of ggplot2 and during a reverse dependency check, it became apparent that the prospective ggplot2 3.5.0 would break bayesplot.
This PR updates the
legend_move()function to deal with the incoming changes.Additionally, it removes the deprecated use of
legend.text.alignandfacet_grid(facet = ...).To test the code changes with the release candidate, you can install it with the code below:
The release of ggplot2 3.5.0 is scheduled for the 12th of February. The progress of the release can be tracked in tidyverse/ggplot2#5588. We hope that this PR might help bayesplot get out a fix if necessary.