Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mcmc_rhat() bug, add mcmc diagnostics _data() functions. #110

Merged
merged 2 commits into from
Sep 8, 2017
Merged

Conversation

tjmahr
Copy link
Collaborator

@tjmahr tjmahr commented Sep 8, 2017

closes #105

@tjmahr tjmahr requested a review from jgabry September 8, 2017 16:37
Copy link
Member

@jgabry jgabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Just one thing: you have mcmc_neff_data defined twice (line 213 and also later at line 285). Can you remove one of them? Other than that I think this is ready to go.

@@ -280,6 +280,14 @@ mcmc_neff_hist <- function(ratio, ..., binwidth = NULL) {
yaxis_ticks(FALSE)
}

#' @rdname MCMC-diagnostics
#' @export
mcmc_neff_data <- function(ratio, ...) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second time mcmc_neff_data is defined.

@jgabry
Copy link
Member

jgabry commented Sep 8, 2017

@tjmahr Actually don't worry about removing one of the mcmc_neff_data definitions. I can just take care of that now while I'm working on bayesplot stuff.

@jgabry jgabry merged commit ac2b5e7 into master Sep 8, 2017
@tjmahr tjmahr deleted the iss105 branch September 8, 2017 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when plotting values for a corr_matrix with mcmc_rhat
2 participants