Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iter1 option to mcmc_trace() to start iteration counting after warmup #155

Merged
merged 9 commits into from
Sep 12, 2018

Conversation

mcol
Copy link
Contributor

@mcol mcol commented Jun 1, 2018

Fixes #14.

@codecov-io
Copy link

codecov-io commented Jun 5, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@8a016cb). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #155   +/-   ##
=========================================
  Coverage          ?   98.74%           
=========================================
  Files             ?       30           
  Lines             ?     3997           
  Branches          ?        0           
=========================================
  Hits              ?     3947           
  Misses            ?       50           
  Partials          ?        0
Impacted Files Coverage Δ
R/mcmc-traces.R 95.53% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a016cb...5f4f98e. Read the comment docs.

Copy link
Member

@jgabry jgabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Just a few small changes requested (see comments). Also, can you add an entry to the NEWS file?

R/mcmc-traces.R Outdated Show resolved Hide resolved
R/mcmc-traces.R Outdated Show resolved Hide resolved
@tjmahr tjmahr merged commit eb08390 into stan-dev:master Sep 12, 2018
@mcol mcol deleted the fix_14 branch July 9, 2019 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants