-
-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove extra space in mcmc_areas #230
Conversation
Codecov Report
@@ Coverage Diff @@
## master #230 +/- ##
=======================================
Coverage 99.28% 99.28%
=======================================
Files 31 31
Lines 3928 3939 +11
=======================================
+ Hits 3900 3911 +11
Misses 28 28
Continue to review full report at Codecov.
|
While we are under the hood for this one, I'd like to fix the clipping where the line in the top panel gets cut off. The demos you supply here appear to fix this problem, but I can still get it if I use I'm trying the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you try out your diagnostic plots using the updated version?
Good call, thanks.
Yup, will check now. |
Do you mean the same set of plots I made above? I made them again (although I forgot to set a seed last time so they'll look a bit different). They still look good after your change. Here's using default arguments: And here's using |
Fixes #218
Copying from my comment in #218:
after playing around with a bunch of options and trying with different numbers of parameters, what ended up working best (I think) was to use an additive expansion that decreases with the number of parameters. I put this on a branch
remove-extra-space-mcmc_areas
. Here's a comparison with the current master branch:For 2, 4, 10, and 20 parameters (simulated from standard normals) here is what the current master branch produces:
![areas_old](https://user-images.githubusercontent.com/7796803/85243932-2bc50f80-b411-11ea-8312-fe4a07247a70.png)
and here is what the version in this PR looks like for the same parameters: