Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boundary corrected KDE values and flag: ppc_loo_pit_overlay() #235

Merged
merged 41 commits into from
Oct 23, 2020
Merged

Boundary corrected KDE values and flag: ppc_loo_pit_overlay() #235

merged 41 commits into from
Oct 23, 2020

Commits on Aug 13, 2020

  1. boundary corrected KDE flag for ppc_loo_pit_overlay

    @ecoronado92
    ecoronado92 committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    dfc156f View commit details
    Browse the repository at this point in the history

  2. added missing , in geom_line

    @ecoronado92
    ecoronado92 committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    ee095cc View commit details
    Browse the repository at this point in the history

  3. fix doc additions given build check errors

    @ecoronado92
    ecoronado92 committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    18abff9 View commit details
    Browse the repository at this point in the history

  4. attempt fix at rep_id global var build error

    @ecoronado92
    ecoronado92 committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    5ed24be View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2020

  1. Edit parameter description R/ppc-loo.R 

    Co-authored-by: Jonah Gabry <jgabry@gmail.com>
    @ecoronado92 @jgabry
    ecoronado92 and jgabry committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    921df6d View commit details
    Browse the repository at this point in the history

  2. Update R/ppc-loo.R 

    Co-authored-by: Jonah Gabry <jgabry@gmail.com>
    @ecoronado92 @jgabry
    ecoronado92 and jgabry committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    629ad09 View commit details
    Browse the repository at this point in the history

  3. R styling R/ppc-loo.R 

    Co-authored-by: Jonah Gabry <jgabry@gmail.com>
    @ecoronado92 @jgabry
    ecoronado92 and jgabry committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    11f6bf8 View commit details
    Browse the repository at this point in the history

  4. R styling R/ppc-loo.R 

    Co-authored-by: Jonah Gabry <jgabry@gmail.com>
    @ecoronado92 @jgabry
    ecoronado92 and jgabry committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    3174ded View commit details
    Browse the repository at this point in the history

  5. changed bc_kde flag, length consistency issues, and strict sanity che… 

    …ck changes
    @ecoronado92
    ecoronado92 committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    1bf7972 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2020

  1. add test for boundary_correction=TRUE 

    currently fails because of warnings
    @jgabry
    jgabry committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    ed455bc View commit details
    Browse the repository at this point in the history

  2. changes to fix vector ifelse warning bc_pvals

    @ecoronado92
    ecoronado92 committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    015ca3a View commit details
    Browse the repository at this point in the history

  3. add @ecoronado92 as a contributor and update NEWS.md

    @jgabry
    jgabry committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    67d0886 View commit details
    Browse the repository at this point in the history

  4. add ppc_loo_pit_data function to separate plotting from data 

    @ecoronado92 I split out the data computations into the function ppc_loo_pit_data. This makes it easier to check the timing of just the data computation.
    @jgabry
    jgabry committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    cf28e91 View commit details
    Browse the repository at this point in the history

  5. remove browser()

    @jgabry
    jgabry committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    05ba44b View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2020

  1. speed up boundary correction w custom cpp

    @ecoronado92
    ecoronado92 committed Aug 22, 2020
    Configuration menu
    Copy the full SHA
    01adc6d View commit details
    Browse the repository at this point in the history

  2. add suggested_package rstanarm to load Rcpp

    @ecoronado92
    ecoronado92 committed Aug 22, 2020
    Configuration menu
    Copy the full SHA
    0922087 View commit details
    Browse the repository at this point in the history

  3. reverting to non cpp code

    @ecoronado92
    ecoronado92 committed Aug 22, 2020
    Configuration menu
    Copy the full SHA
    feb7c97 View commit details
    Browse the repository at this point in the history

  4. updated cpp code

    @ecoronado92
    ecoronado92 committed Aug 22, 2020
    Configuration menu
    Copy the full SHA
    25a2199 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2020

  1. changed boundary correction approach to one based on reflection trick… 

    … and convolution, code is now fast too
    @ecoronado92
    ecoronado92 committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    73f7c4d View commit details
    Browse the repository at this point in the history

  2. fixed missing comma on parameters in ppc_loo_data()

    @ecoronado92
    ecoronado92 committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    14d1d55 View commit details
    Browse the repository at this point in the history

  3. edit man docs to reflect new grid_len param

    @ecoronado92
    ecoronado92 committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    059395e View commit details
    Browse the repository at this point in the history

  4. edit man docs to reflect new grid_len param

    @ecoronado92
    ecoronado92 committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    7264ef4 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2020

  1. Added flags that current version only works on continuous data and ot… 

    …her functions are more useful for binary data
    @ecoronado92
    ecoronado92 committed Sep 27, 2020
    Configuration menu
    Copy the full SHA
    2e5ca83 View commit details
    Browse the repository at this point in the history

  2. add missing comma to binary flag warning

    @ecoronado92
    ecoronado92 committed Sep 27, 2020
    Configuration menu
    Copy the full SHA
    d065700 View commit details
    Browse the repository at this point in the history

  3. expect warning in unit test rather than silent for checks to pass

    @ecoronado92
    ecoronado92 committed Sep 27, 2020
    Configuration menu
    Copy the full SHA
    3f5ba74 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2020

  1. minor doc edits

    @jgabry
    jgabry committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    3a13526 View commit details
    Browse the repository at this point in the history

  2. warn for binary also if boundary_correction is FALSE

    @jgabry
    jgabry committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    eab8117 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into bc_ppc_loo_overlay

    @jgabry
    jgabry committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    f1dd453 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2020

  1. update DESCRIPTION

    @jgabry
    jgabry committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    6768b81 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2020

  1. set boundary correction to TRUE as default

    @ecoronado92
    ecoronado92 committed Oct 12, 2020
    Configuration menu
    Copy the full SHA
    c72606d View commit details
    Browse the repository at this point in the history

  2. set boundary correction TRUE as default

    @ecoronado92
    ecoronado92 committed Oct 12, 2020
    Configuration menu
    Copy the full SHA
    95fc399 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2020

  1. move boundary_correction argument higher 

    since it's TRUE by default it can go before the arguments to control the density estimation that are only used if FALSE
    @jgabry
    jgabry committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    13a3ffb View commit details
    Browse the repository at this point in the history

  2. Update NEWS.md

    @jgabry
    jgabry committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    c4ea8da View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2020

  1. removed TODO from code on convolution NAs, added as new issues on github

    @ecoronado92
    ecoronado92 committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    bd355d2 View commit details
    Browse the repository at this point in the history

  2. TODO comment merge conflict fixed

    @ecoronado92
    ecoronado92 committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    95275d7 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2020

  1. add reflection method to help text of ppc_loo_pit_overlay()

    @ecoronado92
    ecoronado92 committed Oct 17, 2020
    Configuration menu
    Copy the full SHA
    ad18ea7 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2020

  1. add Boneva et al citation

    @jgabry
    jgabry committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    6a60492 View commit details
    Browse the repository at this point in the history

  2. xlim -> [0,1] if using boundary correction

    @jgabry
    jgabry committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    3a76b7d View commit details
    Browse the repository at this point in the history

  3. Update ppc-loo.R

    @jgabry
    jgabry committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    4b79f92 View commit details
    Browse the repository at this point in the history

  4. use prettier x-axis labels

    @jgabry
    jgabry committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    4e4b46c View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2020

  1. Also test with boundary_correction=FALSE

    @jgabry
    jgabry committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    a649e20 View commit details
    Browse the repository at this point in the history