Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix y axis for ppc_loo_pit_qq() with 'compare = "normal"' #243

Merged
merged 5 commits into from
Oct 20, 2020
Merged

Fix y axis for ppc_loo_pit_qq() with 'compare = "normal"' #243

merged 5 commits into from
Oct 20, 2020

Conversation

fweber144
Copy link
Contributor

This fixes #240. Notes:

  • I have updated the documentation as well as possible. But I might have missed some places in the documentation which need to get updated, too.
  • I have moved two lines of code in "tests/testthat/test-ppc-loo.R" which I think got misplaced.

jgabry
jgabry approved these changes Oct 20, 2020
View reviewed changes
Copy link
Member

@jgabry jgabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! And thanks for adding the NEWS item.

@jgabry jgabry merged commit 036f7c5 into stan-dev:master Oct 20, 2020
@fweber144 fweber144 deleted the y_loo_pit_qq branch October 11, 2021 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgabry jgabry jgabry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ppc_loo_pit_qq() with 'compare = "normal"'
2 participants
@fweber144 @jgabry