Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better loo_pit_qq plots #307

Merged
merged 2 commits into from
Jan 17, 2024
Merged

better loo_pit_qq plots #307

merged 2 commits into from
Jan 17, 2024

Conversation

avehtari
Copy link
Contributor

@avehtari avehtari commented Oct 25, 2023

EDIT: fixes #296

loo_pit_qq plots were using geom_qq + geom_qq_line, but that line was not useful in these plots. geom_qq_line is useful if the mean and scale of the data can be different and only the shape matters. When plotting PITs, they are constrained in range [0,1] and the qq's should follow the diagonal. When plotting with compare='normal', the reference line should stiill be diagonal. This PR fixes the line and sets axis limit for the uniform qq-plot to be (0,1). Examples of old and new plots

Old uniform, as the line is diagonal it makes it more difficult to see the relevant difference:
image

New uniform:
image

Old normal:
image

New normal:
image

@avehtari avehtari requested a review from jgabry October 25, 2023 17:06
@jgabry
Copy link
Member

jgabry commented Jan 17, 2024

I think this is only failing because the visual tests detected the change to the plot. I will update the stored svg file and merge.

@jgabry jgabry merged commit 14f9833 into master Jan 17, 2024
0 of 6 checks passed
@jgabry jgabry deleted the fix-ppc_loo_pit_qq branch January 17, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ppc_loo_pit_qq theoretical line
2 participants