Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: fixes #296
loo_pit_qq plots were using geom_qq + geom_qq_line, but that line was not useful in these plots. geom_qq_line is useful if the mean and scale of the data can be different and only the shape matters. When plotting PITs, they are constrained in range [0,1] and the qq's should follow the diagonal. When plotting with
compare='normal'
, the reference line should stiill be diagonal. This PR fixes the line and sets axis limit for the uniform qq-plot to be (0,1). Examples of old and new plotsOld uniform, as the line is diagonal it makes it more difficult to see the relevant difference:
![image](https://private-user-images.githubusercontent.com/6705400/278090959-61bdcad1-e254-4db6-a8e9-3ea2f75bce19.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjM2OTQ4MjQsIm5iZiI6MTcyMzY5NDUyNCwicGF0aCI6Ii82NzA1NDAwLzI3ODA5MDk1OS02MWJkY2FkMS1lMjU0LTRkYjYtYThlOS0zZWEyZjc1YmNlMTkucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgxNSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MTVUMDQwMjA0WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MDM2YTkzYTQ5MDhjOTlmZWRkMGQwMGQ5ODJlZDViNzcyZGIzNGU0Y2NjMzRjNjQ4YzViYTQwMWQ0NGM2MTM3NiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.R29XP8-U6h4y_o3eWZVsZiyf0kvX8ACdEYHdCCKyOlQ)
New uniform:
![image](https://private-user-images.githubusercontent.com/6705400/278090305-cf41875e-5603-4a6a-be59-abcbab00d991.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjM2OTQ4MjQsIm5iZiI6MTcyMzY5NDUyNCwicGF0aCI6Ii82NzA1NDAwLzI3ODA5MDMwNS1jZjQxODc1ZS01NjAzLTRhNmEtYmU1OS1hYmNiYWIwMGQ5OTEucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgxNSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MTVUMDQwMjA0WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZGFjYjllODFlNjg5MmU3YWViMjUxNzMzOTI5MmMzMjljNWFmYTFmM2E5NDk3NGRmOWE5YTA4YjA1YjE2OGNjZSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.UhEHzftNOx3dtSnAFudN9ZuUXaJ0urlG_vVk5ipC6k8)
Old normal:
![image](https://private-user-images.githubusercontent.com/6705400/278091261-60da9f3e-b15a-4e7e-875f-7d3ac8e79915.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjM2OTQ4MjQsIm5iZiI6MTcyMzY5NDUyNCwicGF0aCI6Ii82NzA1NDAwLzI3ODA5MTI2MS02MGRhOWYzZS1iMTVhLTRlN2UtODc1Zi03ZDNhYzhlNzk5MTUucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgxNSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MTVUMDQwMjA0WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NjVjOWZiN2IyM2ZjMDQzNzlkYTNjMTEzNjE2ZGM4OWZiNTlhMDBkY2I2ZmM4NDFlM2QyMTNmMzJlNmE5Y2QyYiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.rNE_zFdXG61ik7amL0DnxTZAfxU2bvwlQQLKoV-KT2U)
New normal:
![image](https://private-user-images.githubusercontent.com/6705400/278090423-6430a394-956a-4214-878b-f913849f4dc6.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjM2OTQ4MjQsIm5iZiI6MTcyMzY5NDUyNCwicGF0aCI6Ii82NzA1NDAwLzI3ODA5MDQyMy02NDMwYTM5NC05NTZhLTQyMTQtODc4Yi1mOTEzODQ5ZjRkYzYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgxNSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MTVUMDQwMjA0WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NTRiYmQ4Zjc0MWIwYTgzMDdmNjBiZmNiOGNkYmMyZWNiYWM5YzM1NzE4NTQ3YmI1ZWM1NzhjOTM0ZjIxYmEwYiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.dn1WYC-va7tRpoF6AUh2FURJj_QqVg-LTqLYkbEuUA8)