Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare v1.11.0 #311

Merged
merged 15 commits into from
Jan 30, 2024
Merged

Prepare v1.11.0 #311

merged 15 commits into from
Jan 30, 2024

Conversation

jgabry
Copy link
Member

@jgabry jgabry commented Jan 17, 2024

Branch for bayesplot v1.11.0

@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (55e5b20) 98.52% compared to head (0eaff59) 98.52%.

❗ Current head 0eaff59 differs from pull request most recent head df74163. Consider uploading reports for the commit df74163 to get more accurate results

Files Patch % Lines
R/ppc-loo.R 83.33% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #311   +/-   ##
=======================================
  Coverage   98.52%   98.52%           
=======================================
  Files          35       35           
  Lines        5007     5018   +11     
=======================================
+ Hits         4933     4944   +11     
  Misses         74       74           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jgabry jgabry marked this pull request as ready for review January 22, 2024 16:51
@jgabry
Copy link
Member Author

jgabry commented Jan 30, 2024

There appears to be some change in R-devel that very slightly affects the svgs used for the visual tests. I don't think there's a way to get this to pass on release and devel because then we would need different sets of svgs. I think we'll just have to update the svgs after the current devel is released.

We'll also need to update the visual tests after the next ggplot2 release since they are also affected by that.

@jgabry
Copy link
Member Author

jgabry commented Jan 30, 2024

Everything is passing except on r-devel for the reason explained above (the SVGs). Will merge and submit the release.

@jgabry jgabry merged commit 51234bb into master Jan 30, 2024
5 of 6 checks passed
@jgabry jgabry deleted the prepare-v1.11.0 branch January 30, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants