Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent pathfinder when 0 parameters, warn if too many PSIS requested #1221

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

WardBrian
Copy link
Member

Submisison Checklist

  • Run tests: ./runCmdStanTests.py src/test
  • Declare copyright holder and open-source license: see below

Summary:

Closes #1208: warning when more PSIS draws are requested than total number of draws from single-pathfinders
Closes #1220: disallows pathfinder when the model has no parameters.

Arguably these could be put in the stan-dev/stan repo. I'm open to either

Documentation:

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Simons Foundation
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@mitzimorris
Copy link
Member

Arguably these could be put in the stan-dev/stan repo. I'm open to either

Error checks should go closest to where the error is made - since these are bad configs/requests, CmdStan is fine.

Long term, putting all the config checking into Stan makes sense - in the meantime, more duct tape!

Copy link
Member

@mitzimorris mitzimorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!
thanks!

@WardBrian WardBrian merged commit 156ffc0 into develop Nov 9, 2023
1 check passed
@WardBrian WardBrian deleted the fix/1208-1220-pathfinder-config branch November 9, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants