[Waiting on Stan PR] Adds psis_resample and calculate_lp as options for pathfinder #1234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitzimorris
reviewed
Jan 5, 2024
| " from individual pathfinders. If false, returns num_paths * num_draws" | ||
| " samples", | ||
| true)); | ||
| _subarguments.push_back(new arg_single_bool( | ||
| "calculate_lp", "If true, individual pathfinders do not calculate lp." | ||
| "calculate_lp", | ||
| "If true, individual pathfinders do not calculate lp." |
There was a problem hiding this comment.
this seems counter-intuitive - true == do it, false == don't do it?
There was a problem hiding this comment.
Yes! I mixed up the docs, lp values are calculated for true and not for false
WardBrian
approved these changes
Jan 8, 2024
This was referenced Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submisison Checklist
./runCmdStanTests.py src/testSummary:
Adds
psis_resampleandcalculate_lpas options for pathfinderIntended Effect:
How to Verify:
Do we need tests for these? The options are tested in Stan so I think it would be redundant here
Side Effects:
Documentation:
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: