Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catch PCH errors with informative message feature #384

Merged
merged 2 commits into from
Dec 3, 2020
Merged

Conversation

rok-cesnovar
Copy link
Member

Summary

Fixes #321

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Rok Češnovar, Uni. of Ljubljana

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@codecov-io
Copy link

codecov-io commented Dec 3, 2020

Codecov Report

Merging #384 (1883b49) into master (2386876) will decrease coverage by 0.06%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #384      +/-   ##
==========================================
- Coverage   90.25%   90.19%   -0.07%     
==========================================
  Files          12       12              
  Lines        2616     2620       +4     
==========================================
+ Hits         2361     2363       +2     
- Misses        255      257       +2     
Impacted Files Coverage Δ
R/model.R 89.45% <50.00%> (-0.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2386876...1883b49. Read the comment docs.

Copy link
Member

@jgabry jgabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! In general I think grepl(..., fixed=TRUE) is nicer that regexpr(..., fixed=TRUE) > 0, but it doesn't really matter. And we already use the latter already in multiple places in the codebase, so no big deal.

@rok-cesnovar
Copy link
Member Author

Didn know that one(grepl vs regepxr). Is it worth it to open an issue to unify?

@jgabry
Copy link
Member

jgabry commented Dec 3, 2020

Didn know that one(grepl vs regepxr). Is it worth it to open an issue to unify?

Yeah grepl returns T/F, so that's pretty useful. Definitely not a big deal, but could be nice to unify next time one of us is looking for an easy issue to close ;)

@jgabry
Copy link
Member

jgabry commented Dec 3, 2020

Passing all checks so will merge now. I also opened #385 about the grepl vs regexpr.

@jgabry jgabry merged commit f24b5e0 into master Dec 3, 2020
@jgabry jgabry deleted the catch_PCH_errors branch December 3, 2020 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error: PCH file uses an older PCH format that is no longer supported
3 participants