Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give informative error when exposing stan functions with precompiled model #831

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

andrjohns
Copy link
Collaborator

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

Resolves the issues seen when trying to expose Stan functions with a precompiled Stan model

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Andrew Johnson

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2023

Codecov Report

Merging #831 (b2b7d41) into master (f028607) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head b2b7d41 differs from pull request most recent head 04e580c. Consider uploading reports for the commit 04e580c to get more accurate results

@@            Coverage Diff             @@
##           master     #831      +/-   ##
==========================================
+ Coverage   88.27%   88.28%   +0.01%     
==========================================
  Files          12       12              
  Lines        4161     4166       +5     
==========================================
+ Hits         3673     3678       +5     
  Misses        488      488              
Files Changed Coverage Δ
R/model.R 90.62% <100.00%> (+0.02%) ⬆️
R/utils.R 73.86% <100.00%> (+0.16%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jgabry
Copy link
Member

jgabry commented Aug 23, 2023 via email

@jgabry jgabry deleted the informative-error-precompiled branch August 23, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants