-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert Latex tabular to plain markdown format #61
Conversation
With this, the table is properly displayed also in the html version. This fixes #51.
This allows to have better control on the formatting of the tables for both html and pdf outputs while avoiding duplicate code for the two formats. This also removes the few other uses of Latex \tabular, so that more missing tables will now appear in the html document. Since Latex minipages are not displayed in the html version if used directly, in sparse-ragged.Rmd we use knitr:::pandoc_to() to check the format being generated: if html, then we issue standard html table markup, otherwise we use \minipage. The two uses of \caption have been removed and the text now flows as a normal paragraph (idea taken from @enbrown's PR).
tried to build your branch on my system - failed with this error:
local pandoc version and info:
|
found this, but suggestion didn't work on my machine - |
This is an attempt to fix the following error that appears in some systems because of a conflict caused by kableExtra: ! LaTeX Error: Option clash for package xcolor.
I cannot reproduce your error on my system (Ubuntu Linux):
Following this https://stackoverflow.com/questions/54257295/latex-error-option-clash-for-package-xcolor-on-cran-debian-builds, I commented out the inclusion of the There's also another usage of |
I looked at the tables and one of them calls for striping - that too would involve color. I'll remove it and see what happens. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great - one change requested.
Done. I didn't see any difference in output in either the pdf or html, so I guess it was not really necessary. |
This uses an exported function rather than an internal one, and the resulting code is marginally clearer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
many thanks!
Submission Checklist
Summary
With this, the table is properly displayed also in the html version. This fixes #51.
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Marco Colombo
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: