Update doc to use stock RTools toolchain #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WardBrian
requested changes
Apr 22, 2024
src/cmdstan-guide/installation.qmd
Outdated
|
|
||
| Both RTools42 & RTools43 provide 64-bit UCRT toolchains, where RTools42 provides g++-10 and | ||
| RTools43 provides g++-12. The installation/configuration is identical for both toolchains. | ||
| RTools43 provides a 64-bit UCRT toolchains with GCC 12.3. |
There was a problem hiding this comment.
I think only describing rtools43 is fine. This is probably a bit too short and technical to be useful to most users, though.
- Are we sure that the
x86_64-w64-mingw32.static.posixfolder even is UCRT based? - If it is, we should probably retain the note that the UCRT requires windows 10+?
There was a problem hiding this comment.
Yep it's definitely UCRT, mentioned in the toolchain doc.
Good point on keeping the Windows 10 note, didn't mean to delete that.
Any thoughts on changes for making it less technical? I'm not sure what would be useful here
There was a problem hiding this comment.
The best thing might be to say something like "RTools 43 provides all of the necessary tools to build Stan, including a C++ compiler and the make tool" and then link to those docs for more specifics?
There was a problem hiding this comment.
Good shout, will do
WardBrian
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Checklist
<<{ since VERSION }>>Summary
As of this Math PR, CmdStan and models can build and sample with the stock RTools toolchain (no need to install
mingw32-makeorgccvia msys2).This PR updates the docs to remove all references to
mingw32-make, and simplifies the windows toolchain setup to simply installing RTools43 and adding the folders toPATHI've also removed the instructions for RTools40 and RTools42, since I don't think we want to continue maintaining instructions for every version of RTools that is released (this is mostly my opinion, happy to revert)
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Andrew Johnson
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: