Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

print.waic() always warns if any p_waic > 0.4 #117

Closed
mcol opened this issue Aug 9, 2019 · 1 comment
Closed

print.waic() always warns if any p_waic > 0.4 #117

mcol opened this issue Aug 9, 2019 · 1 comment

Comments

@mcol
Copy link
Contributor

mcol commented Aug 9, 2019

Getting a warning each time a waic object is printed out is annoying. The warning should be raised only once when the waic is computed, then only a message should be reported when printing the object (similarly to what is done for psis objects).
mcol added a commit to mcol/loo that referenced this issue Aug 9, 2019
@mcol
Don't issue a warning each time a waic object is printed (stan-dev#117)
1b14c10
mcol added a commit to mcol/loo that referenced this issue Aug 9, 2019
@mcol
Don't issue a warning each time a waic object is printed (stan-dev#117)
ba5d7b2
@jgabry jgabry closed this as completed in 45fd203 Sep 20, 2019
@jgabry
Copy link
Member

jgabry commented Sep 20, 2019

Good idea and thanks for fixing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mcol @jgabry