Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc improvement in loo_subsample.R #238

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Doc improvement in loo_subsample.R #238

merged 1 commit into from
Jan 5, 2024

Conversation

avehtari
Copy link
Collaborator

@avehtari avehtari commented Jan 5, 2024

Improved loo_subsample.R docs, and specifically mention one erratum for the paper by Magnusson et al. (2020)

@avehtari
Copy link
Collaborator Author

avehtari commented Jan 5, 2024

Fixes one part of #237

@avehtari avehtari requested a review from MansMeg January 5, 2024 08:49
@MansMeg
Copy link
Collaborator

MansMeg commented Jan 5, 2024

Lgtm

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (426c2d8) 93.00% compared to head (074d788) 93.00%.
Report is 1 commits behind head on master.

❗ Current head 074d788 differs from pull request most recent head e3525c3. Consider uploading reports for the commit e3525c3 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #238   +/-   ##
=======================================
  Coverage   93.00%   93.00%           
=======================================
  Files          30       30           
  Lines        2788     2788           
=======================================
  Hits         2593     2593           
  Misses        195      195           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avehtari avehtari merged commit a69414b into master Jan 5, 2024
5 of 6 checks passed
@jgabry jgabry deleted the avehtari-patch-1 branch January 16, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants